Fix #115, remove conditional compile on time ref #122
Merged
+202
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* Look up the time accessor corresponding to the chosen reference */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| SC_TimeAccessor_t SC_LookupTimeAccessor(SC_TimeRef_Enum_t TimeRef) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| TempTime = CFE_TIME_GetTime(); | ||
| #endif | ||
| /* Use SC defined time */ | ||
| TempTime = SC_AppData.TimeRef.GetTime(); |
Check notice
Code scanning / CodeQL
Use of non-constant function pointer Note
Define a SC_TimeAccessor_t object and select the correct value for it at compile time, as opposed to preprocessor #if blocks.
jphickey
force-pushed
the
fix-115-timeref
branch
from
d642a4c
to
d7f72d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Define a SC_TimeAccessor_t object and select the correct value for it at compile time, as opposed to preprocessor #if blocks.
Fixes #115
Testing performed
Build and run all tests
Expected behavior changes
None
System(s) tested on
Debian
Additional context
Removes untested preprocessor branches, but retains functionality
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.